Skip to content

Updating default shell when changed for existing users#55496

Merged
eriktate merged 1 commit intomasterfrom
eriktate/update-host-user-default-shell
Jun 11, 2025
Merged

Updating default shell when changed for existing users#55496
eriktate merged 1 commit intomasterfrom
eriktate/update-host-user-default-shell

Conversation

@eriktate
Copy link
Copy Markdown
Contributor

@eriktate eriktate commented Jun 5, 2025

Setting the default shell on a role or static host user only applied on user creation before. This PR updates existing users with any default shell changes.

changelog: Fixed an issue that prevented changes to default shell from propagating for host users and static host users.

@eriktate eriktate requested a review from rosstimothy June 5, 2025 23:54
@eriktate eriktate force-pushed the eriktate/update-host-user-default-shell branch from 66ff6b3 to af80843 Compare June 5, 2025 23:55
@eriktate eriktate force-pushed the eriktate/update-host-user-default-shell branch 3 times, most recently from d12e5da to acc6405 Compare June 9, 2025 14:59
@eriktate eriktate marked this pull request as ready for review June 9, 2025 15:02
@eriktate eriktate requested a review from atburke June 9, 2025 15:02
@github-actions github-actions Bot requested review from EdwardDowling and r0mant June 9, 2025 15:03
@eriktate eriktate force-pushed the eriktate/update-host-user-default-shell branch from acc6405 to 5f3ba6e Compare June 9, 2025 15:23
Comment thread lib/srv/usermgmt_test.go Outdated
@eriktate eriktate force-pushed the eriktate/update-host-user-default-shell branch from 5f3ba6e to 0894f7b Compare June 9, 2025 17:53
@eriktate eriktate requested a review from EdwardDowling June 9, 2025 17:53
Comment thread lib/utils/host/hostusers.go Outdated
@eriktate eriktate requested a review from atburke June 9, 2025 20:20
Comment thread lib/utils/host/hostusers.go Outdated
@eriktate eriktate force-pushed the eriktate/update-host-user-default-shell branch 2 times, most recently from a33949f to ebf6711 Compare June 10, 2025 18:34
Comment thread integration/hostuser_test.go Outdated
Comment thread lib/utils/host/hostusers.go Outdated
@eriktate eriktate force-pushed the eriktate/update-host-user-default-shell branch 3 times, most recently from eeae95c to e60affd Compare June 10, 2025 21:58
@eriktate eriktate force-pushed the eriktate/update-host-user-default-shell branch from e60affd to 95958e1 Compare June 10, 2025 22:02
@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from r0mant June 11, 2025 13:26
@eriktate eriktate added this pull request to the merge queue Jun 11, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 11, 2025
@eriktate eriktate added this pull request to the merge queue Jun 11, 2025
Merged via the queue into master with commit ff7a67d Jun 11, 2025
40 checks passed
@eriktate eriktate deleted the eriktate/update-host-user-default-shell branch June 11, 2025 14:26
@backport-bot-workflows
Copy link
Copy Markdown
Contributor

@eriktate See the table below for backport results.

Branch Result
branch/v15 Failed
branch/v16 Failed
branch/v17 Failed
branch/v18 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants