[v16] Ensure sharing remains enabled if the initial desktop connection attempt fails#55455
Merged
gzdunek merged 2 commits intobranch/v16from Jun 6, 2025
Merged
[v16] Ensure sharing remains enabled if the initial desktop connection attempt fails#55455gzdunek merged 2 commits intobranch/v16from
gzdunek merged 2 commits intobranch/v16from
Conversation
gzdunek
force-pushed
the
gzdunek/backport-55350/v16
branch
from
b5cab1e to
1106394
Compare
gzdunek
added
the
no-changelog
flyinghermit
approved these changes
Jun 5, 2025
ravicious
approved these changes
Jun 5, 2025
Member
ravicious
left a comment
ravicious
left a comment
There was a problem hiding this comment.
I verified that I'm able to connect to a desktop through a browser on v16.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #55350 to branch/v16
EDIT: this problem doesn't happen on v16 as we refresh the page on Reconnect click, so we always start from the clear state.
But it's still worth to backport it.