Skip to content

[v18] Connect Win installer: Update system rather than user path #55448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ravicious merged 1 commit into from
Jun 24, 2025
Merged

[v18] Connect Win installer: Update system rather than user path #55448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions web/packages/teleterm/build_resources/installer.nsh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
# https://nsis.sourceforge.io/EnVar_plug-in

!macro customInstall
# Make EnVar define user env vars instead of system env vars.
EnVar::SetHKCU
# Make EnVar define system env vars since Connect is installed per-machine.
EnVar::SetHKLM
EnVar::AddValue "Path" $INSTDIR\resources\bin

nsExec::ExecToStack '"$INSTDIR\resources\bin\tsh.exe" vnet-install-service'
Expand All @@ -25,7 +25,7 @@
!macroend

!macro customUnInstall
EnVar::SetHKCU
EnVar::SetHKLM
# Inside the uninstaller, $INSTDIR is the directory where the uninstaller lies.
# Fortunately, electron-builder puts the uninstaller directly into the actual installation dir.
# https://nsis.sourceforge.io/Docs/Chapter4.html#varother
Expand Down
Loading