Conversation
gzdunek
approved these changes
Jun 4, 2025
Contributor
gzdunek
left a comment
gzdunek
left a comment
There was a problem hiding this comment.
Thanks for quickly addressing this.
ryanclark
approved these changes
Jun 4, 2025
Contributor
|
@ravicious See the table below for backport results.
|
This was referenced Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55355.
v17.3 made it so that Connect is installed per-machine, but the installer continued to add tsh to the user path rather than the system path.
I have verified that we don't have to worry about any extra migration steps. When installing a new version, the installer first runs the uninstaller of the previous version. So first it's going to remove the tsh dir from the user path and then it's going to add the tsh dir to the system path.
Interestingly, on Windows user env vars takes precedence over system env vars with the exception of path, where the user path is appended to the system path.
changelog: The Windows installer of Teleport Connect now adds the folder with tsh to the system path rather than the user path