Skip to content

allow OSS GitHub connector with public github endpoint#55405

Merged
greedy52 merged 1 commit intomasterfrom
STeve/55352_fix_tctl_create_github
Jun 9, 2025
Merged

allow OSS GitHub connector with public github endpoint#55405
greedy52 merged 1 commit intomasterfrom
STeve/55352_fix_tctl_create_github

Conversation

@greedy52
Copy link
Copy Markdown
Contributor

@greedy52 greedy52 commented Jun 3, 2025 •
edited
Loading

fixes #55352:

changelog: fixed an issue output from tctl sso configure github could not be used with tctl create in OSS Teleport

@greedy52 greedy52 requested a review from bl-nero June 3, 2025 17:10
@greedy52 greedy52 self-assigned this Jun 3, 2025
greedy52
greedy52 commented Jun 3, 2025
View reviewed changes
Comment thread lib/services/github.go
if githubConnector.Spec.APIEndpointURL != "" &&
githubConnector.Spec.APIEndpointURL != types.GithubAPIURL {
return nil, fmt.Errorf("GitHub API endpoint URL is set: %w", ErrRequiresEnterprise)
}
Copy link
Copy Markdown
Contributor Author

@greedy52 greedy52 Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

teleport/api/types/github.go

Lines 273 to 281 in 465e7c5

// GetEndpointURL returns the endpoint URL
func (c *GithubConnectorV3) GetEndpointURL() string {
return GithubURL
}
// GetEndpointURL returns the API endpoint URL
func (c *GithubConnectorV3) GetAPIEndpointURL() string {
return GithubAPIURL
}

@github-actions github-actions Bot requested review from hugoShaka and kopiczko June 3, 2025 17:11
@greedy52 greedy52 added this pull request to the merge queue Jun 9, 2025
Merged via the queue into master with commit 84baead Jun 9, 2025
47 checks passed
@greedy52 greedy52 deleted the STeve/55352_fix_tctl_create_github branch June 9, 2025 15:40
@backport-bot-workflows
Copy link
Copy Markdown
Contributor

backport-bot-workflows Bot commented Jun 9, 2025

@greedy52 See the table below for backport results.

Branch Result
branch/v16 Create PR
branch/v17 Create PR
branch/v18 Create PR

This was referenced Jun 13, 2025
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabrielcorado gabrielcorado gabrielcorado approved these changes

@zmb3 zmb3 zmb3 approved these changes

Assignees

@greedy52 greedy52

Labels

backport/branch/v17 backport/branch/v18 size/sm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tctl configure github by default prints a configuration incompatible with OSS teleport

3 participants

@greedy52 @gabrielcorado @zmb3