Fix validation in PIV PIN and PUK form in Connect, increase new PIN timeout#55401
Merged
Fix validation in PIV PIN and PUK form in Connect, increase new PIN timeout#55401
Conversation
gzdunek
approved these changes
Jun 4, 2025
kimlisa
approved these changes
Jun 5, 2025
Contributor
|
@ravicious See the table below for backport results.
|
This was referenced Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55354.
The form in Connect incorrectly required 4–6 digits whereas tsh accepted 6–8. It's been a problem ever since #47652 added hardware key support to Connect.
Since the old form required 4-6 digits and the new one requires 6–8, I was worried what was going to happen if someone set a 4–5 digit PIN or PUK through the old form. It turns out this never worked anyway since tsh has always enforced 6–8 digits despite what Connect's UI said.
The client-side validation can be tested through the story. The whole flow can be tested in an enterprise cluster with
require_session_mfa: hardware_key_touch_and_pin, then resetting PIV in YubiKey Manager (Applications → PIV → Reset PIV).changelog: Fixed updating the default PIN and PUK for hardware key support in Teleport Connect