Skip to content

[v17] feat(machine-id): Add bot instance details page (web)#55347

Merged
nicholasmarais1158 merged 5 commits intobranch/v17from
nicholasmarais1158/backport-55055-55177-branch/v17
Jun 3, 2025
Merged

[v17] feat(machine-id): Add bot instance details page (web)#55347
nicholasmarais1158 merged 5 commits intobranch/v17from
nicholasmarais1158/backport-55055-55177-branch/v17

Conversation

@nicholasmarais1158
Copy link
Copy Markdown
Contributor

@nicholasmarais1158 nicholasmarais1158 commented Jun 2, 2025

Backport #55055 and #55177 to branch/v17

Depends on: #55201

Changelog: View details for a bot instance

* Add navigation item

* Add bot instances page

* Populate page info

* Add missing license header

* Update bot instance nav icon

* Reword hint text

* Add active at timestamp tooltip

* Rename active at header

* Remove copy and sort

* Lint and test fixes

* Support backend search term filtering

* Simplify code

* Add search term filter auth tests

* Allow disabling `<Table />` loading indicator

* Rework frontend to use backend paging and filter (remove sort)

* Fix lint (ts)

* Remove unused BotInstances icon

* Add URL state (page and search)

* Use nil-safe getters on protos

* Fix crash on items w/o heartbeat data
# Conflicts:
#	api/gen/proto/go/teleport/machineid/v1/bot_instance_service.pb.go
* Add navigation item

* Add bot instances page

* Populate page info

* Add missing license header

* Update bot instance nav icon

* Reword hint text

* Add active at timestamp tooltip

* Rename active at header

* Remove copy and sort

* Lint and test fixes

* Support backend search term filtering

* Simplify code

* Add search term filter auth tests

* Allow disabling `<Table />` loading indicator

* Rework frontend to use backend paging and filter (remove sort)

* Fix lint (ts)

* Remove unused BotInstances icon

* Add URL state (page and search)

* Use nil-safe getters on protos

* Fix crash on items w/o heartbeat data

* Add bot instance details page

* Fix lint (ts)

* Fix formatting (prettier)

* Fix yaml time serialisation

* Rename ButtonIcon from jsx to tsx

* Convert ButtonIcon to tsx

* Fix copy button on row

* Correct casing

* Use `assert.YAMLEq`

* Revert changes to ButtonIcon - too big for this PR
@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from rudream June 2, 2025 10:20
Base automatically changed from nicholasmarais1158/backport-54925-branch/v17 to branch/v17 June 2, 2025 16:51
…158/backport-55055-55177-branch/v17

# Conflicts:
#	lib/web/apiserver.go
#	lib/web/machineid.go
#	lib/web/machineid_test.go
#	web/packages/teleport/src/BotInstances/BotInstances.tsx
#	web/packages/teleport/src/BotInstances/List/BotInstancesList.tsx
#	web/packages/teleport/src/config.ts
#	web/packages/teleport/src/features.tsx
#	web/packages/teleport/src/services/bot/bot.ts
#	web/packages/teleport/src/services/bot/consts.ts
#	web/packages/teleport/src/services/bot/types.ts
#	web/packages/teleport/src/test/helpers/botInstances.ts
@nicholasmarais1158 nicholasmarais1158 added this pull request to the merge queue Jun 3, 2025
Merged via the queue into branch/v17 with commit 76bf0a1 Jun 3, 2025
42 checks passed
@nicholasmarais1158 nicholasmarais1158 deleted the nicholasmarais1158/backport-55055-55177-branch/v17 branch June 3, 2025 09:09
@doggydogworld doggydogworld mentioned this pull request Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants