keystore: retry describe key when applying multi-region kms config#55274
Merged
keystore: retry describe key when applying multi-region kms config#55274
Conversation
kimlisa
approved these changes
May 30, 2025
eriktate
approved these changes
May 30, 2025
public-teleport-github-review-bot
Bot
removed request for
marcoandredinis,
nklaassen and
rosstimothy
marcoandredinis
approved these changes
May 30, 2025
dboslee
added
no-changelog
Contributor
dboslee
added a commit
that referenced
this pull request
Jun 10, 2025
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jun 10, 2025
…53927) (#55212) * keystore: add support for aws kms multi-region key replication (#53927) * keystore: add support for aws kms multi-region key replication * update func name ApplyConfig -> ApplyMultiRegionConfig * more descriptive var out -> describeKeyOut * fix typo * better var names * add comment * renaming vars for readability * refactor multi-region auth config * add comment about cert authority lock * fix typo * move funcs up * update comment * copy whole struct instead of individual values * keystore: retry describe key when applying multi-region kms config (#55274)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This describe key call can fail due to KMS's eventual consistency so wrap it with the retry.