Allow unknown ListUnifiedResourceRequest.Kinds#55171
Merged
rosstimothy merged 1 commit intomasterfrom May 28, 2025
Merged
Conversation
Unknown kinds resulted in the request erroring out and returning an error about unknown kinds. This causes compatibility issues when new kinds are added, i.e. git_server in v17 with a v16 leaf cluster will prevent the leaf cluster resources page from loading in the root web ui. The errors are now treated as if access for unknown kinds are denied which will filter them out and allow any known resources to still be processed and returned.
zmb3
approved these changes
May 27, 2025
marcoandredinis
approved these changes
May 28, 2025
public-teleport-github-review-bot
Bot
removed request for
capnspacehook and
r0mant
Contributor
|
@rosstimothy See the table below for backport results.
|
This was referenced May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unknown kinds resulted in the request erroring out and returning an error about unknown kinds. This causes compatibility issues when new kinds are added, i.e. git_server in v17 with a v16 leaf cluster will prevent the leaf cluster resources page from loading in the root web ui.
The errors are now treated as if access for unknown kinds are denied which will filter them out and allow any known resources to still be processed and returned.
Changelog: Prevent unknown resource kinds from rendering errors in the web UI