Use the correct label for new cache metrics#55153
Merged
espadolini merged 1 commit intomasterfrom May 27, 2025
Merged
Conversation
espadolini
added
no-changelog
Contributor
Author
|
The metric label of the same format as the log component already made it in v15 and v16 releases, is it something that we should not change? Should we emit the metric with both for a couple more major versions? Now that Teleport never internally restarts, the labels should always be of the format |
rosstimothy
approved these changes
May 26, 2025
zmb3
approved these changes
May 27, 2025
public-teleport-github-review-bot
Bot
removed request for
fspmarshall and
kopiczko
Contributor
|
@espadolini See the table below for backport results.
|
This was referenced May 27, 2025
smallinsky
pushed a commit
that referenced
this pull request
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new cache metrics
teleport_cache_healthandteleport_cache_last_reset_secondsand added in #54776 are using a label forcache_componentof the formauth:1:cache, matching the label used for logging rather than the one used for the previously existing metrics. This PR changes the label to usec.targetto match the other two cache metrics.