Use protojson in tctl for marshaling BotInstance resource#55093
Merged
strideynet merged 2 commits intomasterfrom May 27, 2025
Merged
Use protojson in tctl for marshaling BotInstance resource#55093strideynet merged 2 commits intomasterfrom
strideynet merged 2 commits intomasterfrom
Conversation
tigrato
approved these changes
May 23, 2025
zmb3
approved these changes
May 23, 2025
Contributor
|
@strideynet See the table below for backport results.
|
This was referenced May 27, 2025
smallinsky
pushed a commit
that referenced
this pull request
May 29, 2025
* Use protojson in tctl for marshaling BotInstance resource * Fix spelling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when rendered as YAML, the timestamps in the resource would be shown as an object with seconds/microseconds since unix epoch. This patch wraps the resources with ProtoResource153ToLegacy so that the correct
protojsonmarshaler is used instead.changelog: Fixed
tctlrendering of timestamps in BotInstance resource YAML