[v17] fix: preserve saml idp redirect on device trust web auth#55048
Merged
flyinghermit merged 1 commit intobranch/v17from May 22, 2025
Merged
[v17] fix: preserve saml idp redirect on device trust web auth#55048flyinghermit merged 1 commit intobranch/v17from
flyinghermit merged 1 commit intobranch/v17from
Conversation
* handle saml idp sso redirection in deviceWebConfirm * preserve url search property for saml idp sso path * connect: use decodeURI to launch unauthorized session url * handle idp initiated sso url * remove decodeURI from buildUnauthorizedSessionUrl * fix test case name typo
avatus
approved these changes
May 22, 2025
kimlisa
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #54530 to branch/v17
Fixes #54121
changelog: Fixed an issue with Device Trust web authentication redirection that lost the original encoding of SAML authentication data during service provider initiated SAML login.