Skip to content

Remove deprecated Connect code for old kube sessions and arbitrary SSH hosts#55000

Merged
ravicious merged 3 commits intomasterfrom
r7s/teleterm-deprecations
May 21, 2025
Merged

Remove deprecated Connect code for old kube sessions and arbitrary SSH hosts#55000
ravicious merged 3 commits intomasterfrom
r7s/teleterm-deprecations

Conversation

@ravicious
Copy link
Copy Markdown
Member

@ravicious ravicious commented May 21, 2025

This PR removes a bunch of deprecated code that I was supposed to remove a long time ago. 🙃

  • doc.terminal_tsh_kube provided the old way of connecting to kube clusters. It executed tsh kube login first and then left the session open. This was replaced in v14 by transparently creating a local proxy for a kube cluster before opening a shell session, then just setting KUBECONFIG to a config that points to the local proxy.
  • DocumentTshNodeWithLoginHost provided a way to connect to an SSH node in the cluster by doing tsh kube user@host in the command bar. This was removed in v13 and now there's no way to connect to an arbitrary host through Connect's UI anymore.
    • GetServers RPC was used to resolve the host to a specific node in the cluster, as well as to list servers in the cluster. Resource-specific screens were replaced with unified resources. Connections to arbitrary hosts were removed, so the RPC is no longer needed.

The deprecation comments mention migrations, but I don't think they're necessary anymore. doc.terminal_tsh_kube won't blow up, it'll just show a message about the document kind not being supported. DocumentTshNodeWithLoginHost would blow up only if someone executed tsh ssh user@host from the nonexistent command bar in Connect and then closed Connect before the app was able to resolve user@host to a specific SSH node.

@ravicious ravicious requested review from avatus and gzdunek May 21, 2025 15:01
@ravicious ravicious added the no-changelog Indicates that a PR does not require a changelog entry label May 21, 2025
@github-actions github-actions bot requested a review from flyinghermit May 21, 2025 15:01
@ravicious ravicious removed the request for review from flyinghermit May 21, 2025 15:01
Copy link
Copy Markdown
Contributor

@rosstimothy rosstimothy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean up! 🧹 🗑️ 🧽

Copy link
Copy Markdown
Contributor

@gzdunek gzdunek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from avatus May 21, 2025 15:19
@ravicious ravicious added this pull request to the merge queue May 21, 2025
Merged via the queue into master with commit d5dcae5 May 21, 2025
50 checks passed
@ravicious ravicious deleted the r7s/teleterm-deprecations branch May 21, 2025 15:55
@zmb3
Copy link
Copy Markdown
Collaborator

zmb3 commented May 21, 2025

Amazing. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Indicates that a PR does not require a changelog entry size/sm ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants