Remove deprecated Connect code for old kube sessions and arbitrary SSH hosts#55000
Merged
Remove deprecated Connect code for old kube sessions and arbitrary SSH hosts#55000
Conversation
rosstimothy
approved these changes
May 21, 2025
Contributor
rosstimothy
left a comment
There was a problem hiding this comment.
Thanks for the clean up! 🧹 🗑️ 🧽
gzdunek
approved these changes
May 21, 2025
Contributor
gzdunek
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up!
Collaborator
|
Amazing. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes a bunch of deprecated code that I was supposed to remove a long time ago. 🙃
doc.terminal_tsh_kubeprovided the old way of connecting to kube clusters. It executedtsh kube loginfirst and then left the session open. This was replaced in v14 by transparently creating a local proxy for a kube cluster before opening a shell session, then just setting KUBECONFIG to a config that points to the local proxy.DocumentTshNodeWithLoginHostprovided a way to connect to an SSH node in the cluster by doingtsh kube user@hostin the command bar. This was removed in v13 and now there's no way to connect to an arbitrary host through Connect's UI anymore.GetServersRPC was used to resolve the host to a specific node in the cluster, as well as to list servers in the cluster. Resource-specific screens were replaced with unified resources. Connections to arbitrary hosts were removed, so the RPC is no longer needed.The deprecation comments mention migrations, but I don't think they're necessary anymore.
doc.terminal_tsh_kubewon't blow up, it'll just show a message about the document kind not being supported.DocumentTshNodeWithLoginHostwould blow up only if someone executedtsh ssh user@hostfrom the nonexistent command bar in Connect and then closed Connect before the app was able to resolveuser@hostto a specific SSH node.