[v16] feat: Hardware Key Agent validates known keys#54908
Merged
Joerger merged 1 commit intobranch/v16from May 19, 2025
Merged
Conversation
* * Have hardware key agent validate known keys instead of always validating by the PIV slot cert. * Refactor cert check logic with a custom error. * Add test. * Update rfd. * Fix lint. * Address comments. * Require knownKeyFn to be provided. * Require fallbackService to be provided to agent service. * Address comments.
Joerger
force-pushed
the
joerger/v16/skip-validate-piv-cert
branch
from
1efdb06 to
20cb2fc
Compare
github-actions
Bot
added
backport
size/md
tsh
zmb3
approved these changes
May 18, 2025
rosstimothy
approved these changes
May 19, 2025
public-teleport-github-review-bot
Bot
removed the request for review
from greedy52
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport #54691 to branch/v16
Changelog: Hardware Key Agent validates known keys by checking active or expired login session.