Skip to content

MCP access part 4: mcputils#54880

Merged
greedy52 merged 4 commits intomasterfrom
STeve/54705_part_4_mcputils
May 29, 2025
Merged

MCP access part 4: mcputils#54880
greedy52 merged 4 commits intomasterfrom
STeve/54705_part_4_mcputils

Conversation

@greedy52
Copy link
Copy Markdown
Contributor

@greedy52 greedy52 commented May 16, 2025

@greedy52 greedy52 added no-changelog Indicates that a PR does not require a changelog entry MCP MCP Server related labels May 16, 2025
@greedy52 greedy52 mentioned this pull request May 16, 2025
Closed
14 tasks
@greedy52 greedy52 force-pushed the STeve/54705_part_4_mcputils branch 2 times, most recently from 6663438 to 434c060 Compare May 18, 2025 17:00
@greedy52 greedy52 force-pushed the STeve/54705_part_4_mcputils branch from 434c060 to d5a441d Compare May 19, 2025 00:05
@greedy52 greedy52 requested review from Tener and gabrielcorado May 19, 2025 01:03
@greedy52 greedy52 marked this pull request as ready for review May 19, 2025 01:03
@github-actions github-actions Bot requested review from gzdunek and strideynet May 19, 2025 01:04
Tener
Tener reviewed May 19, 2025
View reviewed changes
Comment thread lib/utils/mcputils/stdio.go
Comment thread lib/utils/mcputils/stdio.go Outdated
Comment thread lib/utils/mcputils/stdio.go Outdated
Comment thread lib/utils/mcputils/id_tracker.go Outdated
Comment thread lib/utils/mcputils/id_tracker.go Outdated
Comment thread lib/utils/mcputils/id_tracker.go Outdated
@greedy52 greedy52 requested a review from Tener May 22, 2025 19:43
@greedy52 greedy52 force-pushed the STeve/54705_part_4_mcputils branch from fd45cfe to 25aa569 Compare May 22, 2025 19:51
gabrielcorado
gabrielcorado approved these changes May 22, 2025
View reviewed changes
Comment thread lib/utils/mcputils/id_tracker.go Outdated
Comment thread lib/utils/mcputils/protocol.go
gabrielcorado
gabrielcorado approved these changes May 23, 2025
View reviewed changes
Comment thread lib/utils/mcputils/id_tracker.go
Comment on lines +56 to +57
t.lruCache.Add(msg.ID, msg.Method)
return true
Copy link
Copy Markdown
Contributor

@gabrielcorado gabrielcorado May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Add returns a value indicating whether the key was evicted or not.

Suggested change
t.lruCache.Add(msg.ID, msg.Method)
return true
return !t.lruCache.Add(msg.ID, msg.Method)

Copy link
Copy Markdown
Contributor Author

@greedy52 greedy52 May 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's if an old key is evicted because of the size, which has different meaning than current return. unless we return two different bool. i will leave it out for now.

@greedy52 greedy52 mentioned this pull request May 29, 2025
Merged
@greedy52 greedy52 added this pull request to the merge queue May 29, 2025
@greedy52 greedy52 removed this pull request from the merge queue due to a manual request May 29, 2025
@greedy52 greedy52 enabled auto-merge May 29, 2025 21:12
@greedy52 greedy52 added this pull request to the merge queue May 29, 2025
github-merge-queue Bot pushed a commit that referenced this pull request May 29, 2025
@greedy52
MCP access part 4: mcputils (#54880)
b95339c 
* MCP access part 4: mcp helpers

* address feedback

* address comment, minor edits

* update mcp-go
Merged via the queue into master with commit adcc9d3 May 29, 2025
42 checks passed
@greedy52 greedy52 deleted the STeve/54705_part_4_mcputils branch May 29, 2025 21:58
greedy52 added a commit that referenced this pull request Jun 26, 2025
@greedy52
MCP access part 4: mcputils (#54880)
cf1143e 
* MCP access part 4: mcp helpers

* address feedback

* address comment, minor edits

* update mcp-go
@greedy52 greedy52 mentioned this pull request Jun 26, 2025
Merged
github-merge-queue Bot pushed a commit that referenced this pull request Jul 21, 2025
@greedy52 @gabrielcorado @ravicious
[v18] MCP access (#56143)
37b6b0b 
* Initial PostgreSQL MCP support (#54431)

* feat(mcp): initial postgres mcp

* test(postgres): fix missing mock function

* fix(gomod): go mod tidy all

* refactor: code review suggestions

* fix(tsh): mcp init missing logger

* chore(tsh): missing other route to database field

* refactor: use in-memory net listener

* test(tsh): add mcp db command test

* chore: fix license

* refactor(tsh): move logger init

* test(mcp): sort slices to avoid flakiness

* chore: fix lint

* test(mcp): sort the resources before assertion

* fix(mcp): update error handler for better message

* refactor: code review suggestions

* feat: add external error retriever for more accurate error messages

* refactor: use the same logger init for mcp purposes

* refactor: code review suggestions

* refactor(tsh): rename command to `tsh mcp db start`

* refactor(mcp): protect database resources with rw mutex

* chore: update server godocs

* chore: go mod tidy

* refactor: update command to take list of databases

* chore(mcp): license

* chore(tsh): remove unused function

* refactor: code review suggestions

* refactor(tsh): validate duplicated databases in MCP configuration

* refactor(tsh): rename files to mcp_db

* feat(mcp): add cluster name to the database resource

* fix(tsh): update InitLogger return type (#55479)

* MCP access part 1: update app definition and config (#54706)

* MCP access part 1: update app definition and config

* address feedback

* make -C integrations/operator crd

* MCP access part 2: new role options, access checker, role editor (#54734)

* MCP access part 2: new role options, access checker, role editor

* catch unsupported mcp fields

* simplify mcpToolsToModel

* MCP access part 3: audit events and reporting (#54779)

* MCP access part 3: audit events and reporting

* add new icon, storybook, format

* MCP access part 4: mcputils (#54880)

* MCP access part 4: mcp helpers

* address feedback

* address comment, minor edits

* update mcp-go

* MCP access part 5: Claude desktop config parser (#55179)

* claude desktop config

* rework

* split Config to Config and FileConfig

* add a comment on unofficial linux

* MCP access part 6: "tsh mcp ls" (#55292)

* MCP access part 6: "tsh mcp ls"

* address feedback

* MCP access part 7: MCP app in Web UI (#55306)

* MCP access part 7: MCP app in Web UI

* Make spacing in modal closer to what's in database modal

* add mcp app to ResourceActionButton.story.tsx

* move AppSubKind to shared/services/types.

* remove --format claude (not needed see part 8)

* add jsdoc

---------

Co-authored-by: Rafał Cieślak <rafal.cieslak@goteleport.com>

* MCP access part 8: tsh mcp config (#55370)

* MCP access part 8: tsh mcp login/logout

* change to --format and --config-file

* switch to config and drop logout

* enable debug by default

* remove unused ut functions

* MCP access part 9: tsh mcp connect, stub server, integration test (#55547)

* MCP access part 9: tsh mcp connect, stub server, integration test

* fix tests and lint

* MCP access part 10: server handler (#55644)

* MCP access part 10: server handler

* address feedback and fix docker tests

* add more comments

* minor lint fix

* move set logger default after other checks

* Implement `tsh mcp db config` (#55781)

* feat(tsh): add `tsh mcp db config` subcommand

* chore(claude): fix lint

* refactor: code review suggestions

* refactor: code review suggestions

* test(tsh): add missing option on test case

* chore(tsh): add message on manually adding database URI

* Refactor MCP database access to dial ALPN proxy directly (#55836)

* refactor: dial database instead of using local proxy for MCP servers

* refactor: review suggestions

* manual fixes

* tctl users add/update to support mcp tools trait (#56771)

* tctl users add/update to support mcp tools trait

* revert empty slice capability

* Enhances MCP servers usage with Cursor (#56474)

* feat(mcp): enhances MCP servers usage with Cursor

* refactor: code review suggestions

* mcputils refactor and new mcptest package (#56010)

* mcp server and mcputils refactor

* mcptest package

* allow testing in mcptest

* Teleport MCP demo server (#56637)

* Teleport MCP demo server

* replace guide tool with session tool, and switch to resource label

* add new flag to teleport configure

* replace teleport_session_id with mcp_transport_type

* feat(gomod): update mcp-go to v0.32.0

* eslint-disable-next-line (same in master)

---------

Co-authored-by: Gabriel Corado <gabriel.oliveira@goteleport.com>
Co-authored-by: Rafał Cieślak <rafal.cieslak@goteleport.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tener Tener Tener approved these changes

@gabrielcorado gabrielcorado gabrielcorado approved these changes

Assignees

No one assigned

Labels

MCP MCP Server related no-changelog Indicates that a PR does not require a changelog entry size/lg

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@greedy52 @Tener @gabrielcorado