[v17] Add SID support for PKINIT#54870
Merged
Tener merged 1 commit intobranch/v17from Jun 13, 2025
Merged
Conversation
github-actions
Bot
added
database-access
github-actions
Bot
requested review from
danielashare,
gabrielcorado,
greedy52 and
zmb3
Contributor
|
Amplify deployment status
|
greedy52
approved these changes
May 16, 2025
Contributor
greedy52
left a comment
greedy52
left a comment
There was a problem hiding this comment.
Lets wait v18.0 release testing to test this out before merging the backport.
gabrielcorado
approved these changes
May 16, 2025
Tener
force-pushed
the
tener/backport-54719-v17
branch
from
7e2ef69 to
be3a072
Compare
Contributor
Author
|
Merging now that release testing has validated this change on master. In the meantime there were some other changes on v17 to this area, so I had to do a manual merge to resolve conflicts. I re-tested the updated code against actual SQL Server with Kerberos. |
Tener
force-pushed
the
tener/backport-54719-v17
branch
from
be3a072 to
bede14c
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #54719 to branch/v17.
Manual backport due to conflicts:
make grpcChangelog: Database protocols using Kerberos (SQL Server, Oracle) can now be configured to fetch user SID for Full Enforcement mapping.