Skip active desktop session prompt when per-session MFA is enabled#54848
Merged
Skip active desktop session prompt when per-session MFA is enabled#54848
Conversation
We should check it for a resource's cluster ID (which may be a leaf cluster) not a static root cluster ID.
zmb3
approved these changes
May 15, 2025
kiosion
approved these changes
May 15, 2025
public-teleport-github-review-bot
Bot
removed the request for review
from kimlisa
Contributor
This was referenced May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was reported that confirming two prompts when starting a desktop session can be annoying. To improve the user experience, we can only display the “another session is active” prompt when per-session MFA is disabled for the target desktop.
Closes #52613
Closes gravitational/customer-sensitive-requests#393
changelog: Disabled the "another session is active" prompt when per-session MFA is enabled, since MFA already enforces user confirmation when starting a desktop session