[v17] Terraform: Fix Access List import#54802
Merged
kopiczko merged 1 commit intobranch/v17from May 15, 2025
Merged
Conversation
The most important bit is set tfschema.TimeValue.Format in CopyToTimestamp so non-nil times are parsed correctly. Otherwise the import results in `parsing time "" as "2006-01-02T15:04:05Z07:00": cannot parse "" as "2006"`. That affected all resources, because all of them have `metadata.expires` field, but AccessList was hit the most because it has `spec.audit.next_audit_date` Timestamp field. The other part is marking more header fields as computed so the `apply` after the `import`` goes smoothly and is less confusing.
hugoShaka
approved these changes
May 14, 2025
smallinsky
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #54775 to branch/v17
changelog: Terraform: Fixed Access List resource import.