Add server-streaming rpc for listing web sessions#54737
Merged
espadolini merged 1 commit intomasterfrom May 13, 2025
Merged
Conversation
espadolini
added
c-bl
rosstimothy
approved these changes
May 13, 2025
public-teleport-github-review-bot
Bot
removed the request for review
from gabrielcorado
Contributor
|
@espadolini See the table below for backport results.
|
This was referenced May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an alternate server-streaming rpc for getting web sessions, using a server stream rather than a unary rpc returning a list, since we've seen large clusters error out due to gRPC message size limits, especially when upgrading to v17 since web sessions now include two private keys rather than one (and RSA keys are pretty big). No internal changes since the only things with need and power to get a list of web sessions are proxies and you're only going to have a few handfuls of those to begin with, so collecting a list in the auth memory is not a problem.
changelog: fixed Proxy cache initialization errors in clusters with large amounts of open web sessions