Move auth preference module validation to RPC layer#54687
Merged
rosstimothy merged 1 commit intomasterfrom May 13, 2025
Merged
Conversation
rosstimothy
force-pushed
the
tross/validate_auth_pref
branch
2 times, most recently
from
d93e22a to
10dfd8f
Compare
rosstimothy
force-pushed
the
tross/validate_auth_pref
branch
2 times, most recently
from
9bb8672 to
08ea3cc
Compare
hugoShaka
approved these changes
May 12, 2025
espadolini
reviewed
May 13, 2025
espadolini
approved these changes
May 13, 2025
public-teleport-github-review-bot
Bot
removed the request for review
from kopiczko
rosstimothy
force-pushed
the
tross/validate_auth_pref
branch
from
199f64a to
eb5967b
Compare
rosstimothy
force-pushed
the
tross/validate_auth_pref
branch
from
eb5967b to
08a478b
Compare
The module validation rejects auth preferences that have second factor disabled without the environment variable override. Doing this in the storage layer means that in order to disable second factor the environment variable needs to be set on _all_ teleport processes not just Auth. This can result in caches of downstream agents from becoming healthy until the manual override is applied. The intent is to prevent modifying an the auth preference to disable second factor, which when moved to the RPC layer, has the same affect without the possibility of caches performing extra validation.
rosstimothy
force-pushed
the
tross/validate_auth_pref
branch
from
08a478b to
5dcc45e
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
@rosstimothy See the table below for backport results.
|
rosstimothy
added a commit
that referenced
this pull request
May 13, 2025
The module validation rejects auth preferences that have second factor disabled without the environment variable override. Doing this in the storage layer means that in order to disable second factor the environment variable needs to be set on _all_ teleport processes not just Auth. This can result in caches of downstream agents from becoming healthy until the manual override is applied. The intent is to prevent modifying an the auth preference to disable second factor, which when moved to the RPC layer, has the same affect without the possibility of caches performing extra validation.
rosstimothy
added a commit
that referenced
this pull request
May 13, 2025
The module validation rejects auth preferences that have second factor disabled without the environment variable override. Doing this in the storage layer means that in order to disable second factor the environment variable needs to be set on _all_ teleport processes not just Auth. This can result in caches of downstream agents from becoming healthy until the manual override is applied. The intent is to prevent modifying an the auth preference to disable second factor, which when moved to the RPC layer, has the same affect without the possibility of caches performing extra validation.
rosstimothy
added a commit
that referenced
this pull request
May 13, 2025
The module validation rejects auth preferences that have second factor disabled without the environment variable override. Doing this in the storage layer means that in order to disable second factor the environment variable needs to be set on _all_ teleport processes not just Auth. This can result in caches of downstream agents from becoming healthy until the manual override is applied. The intent is to prevent modifying an the auth preference to disable second factor, which when moved to the RPC layer, has the same affect without the possibility of caches performing extra validation.
rosstimothy
added a commit
that referenced
this pull request
May 13, 2025
The module validation rejects auth preferences that have second factor disabled without the environment variable override. Doing this in the storage layer means that in order to disable second factor the environment variable needs to be set on _all_ teleport processes not just Auth. This can result in caches of downstream agents from becoming healthy until the manual override is applied. The intent is to prevent modifying an the auth preference to disable second factor, which when moved to the RPC layer, has the same affect without the possibility of caches performing extra validation.
rosstimothy
added a commit
that referenced
this pull request
May 13, 2025
The module validation rejects auth preferences that have second factor disabled without the environment variable override. Doing this in the storage layer means that in order to disable second factor the environment variable needs to be set on _all_ teleport processes not just Auth. This can result in caches of downstream agents from becoming healthy until the manual override is applied. The intent is to prevent modifying an the auth preference to disable second factor, which when moved to the RPC layer, has the same affect without the possibility of caches performing extra validation.
rosstimothy
added a commit
that referenced
this pull request
May 13, 2025
The module validation rejects auth preferences that have second factor disabled without the environment variable override. Doing this in the storage layer means that in order to disable second factor the environment variable needs to be set on _all_ teleport processes not just Auth. This can result in caches of downstream agents from becoming healthy until the manual override is applied. The intent is to prevent modifying an the auth preference to disable second factor, which when moved to the RPC layer, has the same affect without the possibility of caches performing extra validation.
rosstimothy
added a commit
that referenced
this pull request
May 13, 2025
The module validation rejects auth preferences that have second factor disabled without the environment variable override. Doing this in the storage layer means that in order to disable second factor the environment variable needs to be set on _all_ teleport processes not just Auth. This can result in caches of downstream agents from becoming healthy until the manual override is applied. The intent is to prevent modifying an the auth preference to disable second factor, which when moved to the RPC layer, has the same affect without the possibility of caches performing extra validation.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
May 15, 2025
The module validation rejects auth preferences that have second factor disabled without the environment variable override. Doing this in the storage layer means that in order to disable second factor the environment variable needs to be set on _all_ teleport processes not just Auth. This can result in caches of downstream agents from becoming healthy until the manual override is applied. The intent is to prevent modifying an the auth preference to disable second factor, which when moved to the RPC layer, has the same affect without the possibility of caches performing extra validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The module validation rejects auth preferences that have second factor disabled without the environment variable override. Doing this in the storage layer means that in order to disable second factor the environment variable needs to be set on all teleport processes not just Auth. This can result in caches of downstream agents from becoming healthy until the manual override is applied. The intent is to prevent modifying an the auth preference to disable second factor, which when moved to the RPC layer, has the same affect without the possibility of caches performing extra validation.
Changelog: Prevent restrictive validation of cluster auth preferences from causing non-auth instances to become healthy.