[v17] MWI: Fix certain --no- flags failing to override config file#54651
Merged
timothyb89 merged 4 commits intobranch/v17from May 9, 2025
Merged
[v17] MWI: Fix certain --no- flags failing to override config file#54651timothyb89 merged 4 commits intobranch/v17from
--no- flags failing to override config file#54651timothyb89 merged 4 commits intobranch/v17from
Conversation
This fixes a few instances where `--no-` flags were unable to override config file parameters as we didn't check if the flag was actually set by the user. This now uses the value parsed by kingpin directly if an associated `*SetByUser` flag is also set, making it possible to use, e.g., `--no-oneshot` to disable oneshot mode if also loading a `tbot.yaml` with the flag enabled. Most `BoolVar()` uses in tbot don't apply - only those that can plausibly be overridden by a config file. That means only `start` type commands, and then only flags which produce configs that can actually be overridden, which excludes most generated service definitions.
strideynet
approved these changes
May 9, 2025
boxofrad
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #54402 to branch/v17
changelog: Machine ID: Allow
--no-oneshotand similar flags to override config file values