Convert access requests to new cache mechanism#54580
Closed
rosstimothy wants to merge 1 commit intomasterfrom
Closed
Convert access requests to new cache mechanism#54580rosstimothy wants to merge 1 commit intomasterfrom
rosstimothy wants to merge 1 commit intomasterfrom
Conversation
rosstimothy
added
the
no-changelog
rosstimothy
force-pushed
the
tross/access_requests
branch
from
38f08b9 to
b1351b8
Compare
rosstimothy
force-pushed
the
tross/access_requests
branch
from
b1351b8 to
0ce4550
Compare
Moves access requests to the new cache collection scheme that was introduced in #52210. No additional functionality changes have been made here. This should be a purely mechanical translation to the new internal caching machinery.
rosstimothy
force-pushed
the
tross/access_requests
branch
from
0ce4550 to
554caaa
Compare
kopiczko
reviewed
May 8, 2025
Comment on lines
+34
to
+39
| store: newStore(map[string]func(types.AccessRequest) string{ | ||
| "default": func(types.AccessRequest) string { return "default" }, | ||
| }), | ||
| fetcher: func(ctx context.Context, loadSecrets bool) ([]types.AccessRequest, error) { | ||
| return nil, nil | ||
| }, |
Contributor
There was a problem hiding this comment.
Sorry, I'm very out of my depth here, but this is somewhat suspicious.
From what I've seen for the store index we usually have something like:
store: newStore(map[proxyServerIndex]func(types.Server) string{
proxyServerNameIndex: func(u types.Server) string {
return u.GetName()
},
}),
Isn't that needed here?
Also why is the fetcher returning nil?
Contributor
There was a problem hiding this comment.
Access requests in the cache are weird because the auth doesn't actually cache them but they must be usable in watchers; we should make it more explicit that this is what's happening, or find a better way to deal with resource kinds that are watchable and fanned out but not actually handled by the cache.
Contributor
There was a problem hiding this comment.
Some comment could be useful
Contributor
Author
|
Closing in favor of #54637 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves access requests to the new cache collection scheme that was introduced in #52210. No additional functionality changes have been made here. This should be a purely mechanical translation to the new internal caching machinery.