fix: fixes a possible deadlock in kube moderator joining#54500
Merged
fix: fixes a possible deadlock in kube moderator joining#54500
Conversation
This PR addresses a bug in the Kubernetes session join logic where a joined session could hang under specific conditions. The issue occurred when one or more peers triggered multiple terminal resize events in rapid succession. The client handling the resize was only performing a single resize operation and failing to respond to subsequent events, resulting in the terminal becoming unresponsive. This led to a state where session data was no longer displayed to moderators or observers, effectively freezing the shared session view. The fix ensures proper handling of repeated resize events to maintain session responsiveness and continuity. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
zmb3
approved these changes
May 3, 2025
Collaborator
zmb3
left a comment
zmb3
left a comment
There was a problem hiding this comment.
Change looks good. If there's a way to get some test coverage on this we could always use more tests for moderation.
avatus
approved these changes
May 5, 2025
public-teleport-github-review-bot
Bot
removed the request for review
from boxofrad
zmb3
reviewed
May 5, 2025
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
Contributor
Author
I can take a look later but I think it requires a bit of work. This code isn't directly tested. Even integration tests use a custom client. |
Contributor
This was referenced May 5, 2025
tigrato
added a commit
that referenced
this pull request
May 5, 2025
* fix: fixes a possible deadlock in kube moderator joining This PR addresses a bug in the Kubernetes session join logic where a joined session could hang under specific conditions. The issue occurred when one or more peers triggered multiple terminal resize events in rapid succession. The client handling the resize was only performing a single resize operation and failing to respond to subsequent events, resulting in the terminal becoming unresponsive. This led to a state where session data was no longer displayed to moderators or observers, effectively freezing the shared session view. The fix ensures proper handling of repeated resize events to maintain session responsiveness and continuity. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> * Update lib/client/kubesession.go Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
May 9, 2025
* fix: fixes a possible deadlock in kube moderator joining (#54500) * fix: fixes a possible deadlock in kube moderator joining This PR addresses a bug in the Kubernetes session join logic where a joined session could hang under specific conditions. The issue occurred when one or more peers triggered multiple terminal resize events in rapid succession. The client handling the resize was only performing a single resize operation and failing to respond to subsequent events, resulting in the terminal becoming unresponsive. This led to a state where session data was no longer displayed to moderators or observers, effectively freezing the shared session view. The fix ensures proper handling of repeated resize events to maintain session responsiveness and continuity. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> * Update lib/client/kubesession.go Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> * fix * fix --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug in the Kubernetes session join logic where a joined session could hang under specific conditions. The issue occurred when one or more peers triggered multiple terminal resize events in succession.
The client handling the resize was only performing a single resize operation and failing to respond to subsequent events, resulting in the terminal becoming unresponsive. This led to a state where session data was no longer displayed to moderators or observers, effectively freezing the shared session view. The fix ensures proper handling of repeated resize events to maintain session responsiveness and continuity.
Changelog: Fixed a possible moderator/observer terminal freeze when joining a Kubernetes moderated session.