Convert integrations resources to new in memory cache collection#54487
Merged
rosstimothy merged 1 commit intomasterfrom May 5, 2025
Merged
Convert integrations resources to new in memory cache collection#54487rosstimothy merged 1 commit intomasterfrom
rosstimothy merged 1 commit intomasterfrom
Conversation
rosstimothy
added
the
no-changelog
rosstimothy
force-pushed
the
tross/cache_integrations
branch
2 times, most recently
from
23ac159 to
ff2bad3
Compare
zmb3
approved these changes
May 2, 2025
| func TestAccessMonitoringRules(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| p := newTestPack(t, ForAuth) |
Collaborator
There was a problem hiding this comment.
Some day we should make newTestPack do the t.Cleanup itself.
I prefer that functions that take a *testing.T register their own cleanups, and functions that don't return a closer or a func that can be deferred, etc.
It's hard to tell when you're expected to clean up after things if we're not consistent here.
Anyway, end rant. :-)
espadolini
approved these changes
May 5, 2025
public-teleport-github-review-bot
Bot
removed request for
flyinghermit and
fspmarshall
Moves integrations, access monitoring rules, and plugin static credentials to the new cache collection scheme that was introduced in #52210. No additional functionality changes have been made here. This should be a purely mechanical translation to the new internal caching machinery.
rosstimothy
force-pushed
the
tross/cache_integrations
branch
from
ff2bad3 to
92c785f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves integrations, access monitoring rules, and plugin static credentials to the new cache collection scheme that was introduced in #52210. No additional functionality changes have been made here. This should be a purely mechanical translation to the new internal caching machinery.