Web: remove unified resource card styling when require request#54427
Merged
Web: remove unified resource card styling when require request#54427
Conversation
kimlisa
added
backport/branch/v15
no-changelog
flyinghermit
approved these changes
Apr 30, 2025
kimlisa
force-pushed
the
lisa/remove-style
branch
2 times, most recently
from
2f144d3 to
07705c2
Compare
avatus
approved these changes
May 1, 2025
Contributor
kimlisa
added a commit
that referenced
this pull request
May 1, 2025
* Fill non requestable action buttons
kimlisa
added a commit
that referenced
this pull request
May 1, 2025
github-merge-queue Bot
pushed a commit
that referenced
this pull request
May 1, 2025
… (#54465) * Fill non requestable action buttons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed with UX team, we decided to remove all styling regarding resources that require access request.
In exchange for removing the background, all action buttons are now filled except for buttons that are to request access (to help differentiate the buttons)
This handles the confusion that resources that required access may have looked
disabled.before:
after (notice filled action buttons)
changelog: Removed background color for resources that required access request in the web UI Resources view.