Convert access lists to new in memory cache collection#54389
Merged
rosstimothy merged 1 commit intomasterfrom May 5, 2025
Merged
Convert access lists to new in memory cache collection#54389rosstimothy merged 1 commit intomasterfrom
rosstimothy merged 1 commit intomasterfrom
Conversation
rosstimothy
added
the
no-changelog
rosstimothy
force-pushed
the
tross/cache_access_list
branch
from
dd744e2 to
2c2e3cf
Compare
fspmarshall
approved these changes
Apr 29, 2025
Comment on lines
+164
to
+174
| accessListMemberStoreNameIndex: func(r *accesslist.AccessListMember) string { | ||
| return r.Spec.AccessList + "/" + r.GetName() | ||
| }, | ||
| accessListMemberStoreKindIndex: func(r *accesslist.AccessListMember) string { | ||
| return r.Spec.AccessList + "/" + r.Spec.MembershipKind + "/" + r.GetName() | ||
| }, |
| } | ||
|
|
||
| // CountAccessListMembers will count all access list members. | ||
| func (c *Cache) CountAccessListMembers(ctx context.Context, accessListName string) (uint32, uint32, error) { |
Contributor
There was a problem hiding this comment.
nit: used named return types or document the meaning of the positional uint32s.
rosstimothy
force-pushed
the
tross/cache_access_list
branch
from
5a91a7c to
1ad2f90
Compare
espadolini
reviewed
Apr 29, 2025
espadolini
reviewed
Apr 29, 2025
rosstimothy
force-pushed
the
tross/cache_access_list
branch
from
1ad2f90 to
38a62d0
Compare
espadolini
approved these changes
May 5, 2025
Moves access lists, access list members and access list reviews to the new cache collection scheme that was introduced in #52210. No additional functionality changes have been made here. This should be a purely mechanical translation to the new internal caching machinery.
rosstimothy
force-pushed
the
tross/cache_access_list
branch
from
765c38e to
9da6eb6
Compare
public-teleport-github-review-bot
Bot
removed the request for review
from capnspacehook
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves access lists, access list members and access list reviews to the new cache collection scheme that was introduced in #52210. No additional functionality changes have been made here. This should be a purely mechanical translation to the new internal caching machinery.