fix: fixes a possible panic during auth start if upsert operation fails#54323
Merged
fix: fixes a possible panic during auth start if upsert operation fails#54323
Conversation
This PR fixes a possible panic caused by a failure caused by a backend
failure. If the failure occurs, we replaced the user object with the
result of the `{Upsert|Create}User` operation. If the operation fails,
both calls return `nil, err` and when building the error stream, we
accessed a nil user.
Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
rosstimothy
approved these changes
Apr 25, 2025
greedy52
approved these changes
Apr 25, 2025
public-teleport-github-review-bot
Bot
removed the request for review
from kiosion
Contributor
This was referenced Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a potential panic that could occur due to a backend failure. In the event of such a failure, the user object is replaced with the result of the
{Upsert|Create}Useroperation. If this operation also fails, both return nil, err, and since we attempted to access the user during error string construction, a nil pointer dereference could occur.Changelog: Fixed a potential panic during Auth Server startup when the backend returns an error.