MWI: flexibility for AWS Roles Anywhere output#54229
Merged
strideynet merged 7 commits intomasterfrom Apr 24, 2025
Merged
Conversation
strideynet
commented
Apr 23, 2025
strideynet
commented
Apr 23, 2025
| // OverwriteCredentialFile is a flag that indicates whether the output | ||
| // should overwrite the existing credentials file rather than merging with | ||
| // it. | ||
| OverwriteCredentialFile bool `yaml:"overwrite_credential_file,omitempty"` |
Contributor
Author
There was a problem hiding this comment.
I was thinking of perhaps using a string enum here rather than a bool - in case we wanted to add some stricter modes in future (e.g "don't merge and don't overwrite - a safe mode"). WDYT
boxofrad
approved these changes
Apr 23, 2025
| // OverwriteCredentialFile is a flag that indicates whether the output | ||
| // should overwrite the existing credentials file rather than merging with | ||
| // it. | ||
| OverwriteCredentialFile bool `yaml:"overwrite_credential_file,omitempty"` |
ryanclark
approved these changes
Apr 24, 2025
public-teleport-github-review-bot
Bot
removed the request for review
from timothyb89
strideynet
deleted the
strideynet/further-configurability-for-aws-output
branch
Contributor
|
@strideynet See the table below for backport results.
|
This was referenced Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide further flexibility of the AWS Roles Anywhere service:
changelog: More customizability options for the AWS Roles Anywhere MWI service