Convert desktop session dialogs to inline messages#54127
Merged
Conversation
gzdunek
added
no-changelog
gzdunek
force-pushed
the
gzdunek/inline-alerts
branch
from
3e40b19 to
8b751da
Compare
zmb3
approved these changes
Apr 18, 2025
Contributor
gzdunek
added a commit
that referenced
this pull request
May 7, 2025
* Allow clearing the MFA attempt state * Shutdown the websocket connection if the user cancels an MFA prompt * Properly handle situations when abort signal is aborted before we open the websocket * Reconnect the client instead of refreshing the page * Replace "error" status with "disconnected", make it more capable * Propagate errors from the `TdpClient` * Convert dialogs to inline messages * Increase the gap slightly * Revert `.off()` to `.removeListener()` change (cherry picked from commit 921eeca)
github-merge-queue Bot
pushed a commit
that referenced
this pull request
May 7, 2025
* Convert desktop session dialogs to inline messages (#54127) * Allow clearing the MFA attempt state * Shutdown the websocket connection if the user cancels an MFA prompt * Properly handle situations when abort signal is aborted before we open the websocket * Reconnect the client instead of refreshing the page * Replace "error" status with "disconnected", make it more capable * Propagate errors from the `TdpClient` * Convert dialogs to inline messages * Increase the gap slightly * Revert `.off()` to `.removeListener()` change (cherry picked from commit 921eeca) * Make `jest-canvas-mock` available in all packages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribues to #20802
This PR aligns the desktop session component to Teleport Connect environment:
Note that TDP errors are shown as informational alerts. This is because the backend sends "graceful disconnection" events as TDP error alerts. On the frontend side I don't know if the particular error was a "graceful disconnection", so it's better to just show all TDP errors as informational (as before).