Merged
Conversation
Collaborator
|
This approach means that NLA will never work on FIPS builds. This is okay if it's our only option, but some people prefer to run the FIPS builds even where FIPS is not required and they just don't set the How hard would it be to check whether the |
Contributor
Author
|
Not that hard, I changed it |
gzdunek
approved these changes
Apr 25, 2025
zmb3
approved these changes
May 8, 2025
Collaborator
|
@probakowski let's get this merged next week. |
Contributor
|
@probakowski See the table below for backport results.
|
probakowski
added a commit
that referenced
this pull request
Jul 30, 2025
* Disable NLA in FIPS mode * Disable NLA in FIPS mode * lint
probakowski
added a commit
that referenced
this pull request
Jul 30, 2025
* Disable NLA in FIPS mode * Disable NLA in FIPS mode * lint
probakowski
added a commit
that referenced
this pull request
Jul 30, 2025
* Disable NLA in FIPS mode * Disable NLA in FIPS mode * lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encryption used
sspiis not FIPS-compliant, because of that, for now, we will disable NLA in FIPS modechangelog: Disable NLA in FIPS mode