Skip to content

Disable NLA in FIPS mode#54048

Merged
probakowski merged 4 commits intomasterfrom
probakowski/fips-disable-nla
Jul 30, 2025
Merged

Disable NLA in FIPS mode#54048
probakowski merged 4 commits intomasterfrom
probakowski/fips-disable-nla

Conversation

@probakowski
Copy link
Copy Markdown
Contributor

@probakowski probakowski commented Apr 15, 2025

Encryption used sspi is not FIPS-compliant, because of that, for now, we will disable NLA in FIPS mode

changelog: Disable NLA in FIPS mode

@zmb3
Copy link
Copy Markdown
Collaborator

zmb3 commented Apr 15, 2025

This approach means that NLA will never work on FIPS builds. This is okay if it's our only option, but some people prefer to run the FIPS builds even where FIPS is not required and they just don't set the --fips flag when starting Teleport.

How hard would it be to check whether the --fips flag is enabled instead of doing this at compile-time?

@probakowski
Copy link
Copy Markdown
Contributor Author

Not that hard, I changed it

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from kimlisa May 8, 2025 19:43
@zmb3
Copy link
Copy Markdown
Collaborator

zmb3 commented May 16, 2025

@probakowski let's get this merged next week.

@probakowski probakowski added this pull request to the merge queue Jul 30, 2025
Merged via the queue into master with commit c16ee3c Jul 30, 2025
39 checks passed
@probakowski probakowski deleted the probakowski/fips-disable-nla branch July 30, 2025 10:28
@backport-bot-workflows
Copy link
Copy Markdown
Contributor

@probakowski See the table below for backport results.

Branch Result
branch/v16 Failed
branch/v17 Failed
branch/v18 Failed

probakowski added a commit that referenced this pull request Jul 30, 2025
* Disable NLA in FIPS mode

* Disable NLA in FIPS mode

* lint
probakowski added a commit that referenced this pull request Jul 30, 2025
* Disable NLA in FIPS mode

* Disable NLA in FIPS mode

* lint
probakowski added a commit that referenced this pull request Jul 30, 2025
* Disable NLA in FIPS mode

* Disable NLA in FIPS mode

* lint
@probakowski probakowski removed the no-changelog Indicates that a PR does not require a changelog entry label Jul 30, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jul 30, 2025
* Disable NLA in FIPS mode (#54048)

* Disable NLA in FIPS mode

* Disable NLA in FIPS mode

* lint

* Update docs for NLA in FIPS mode (#57310)
github-merge-queue bot pushed a commit that referenced this pull request Jul 30, 2025
* Disable NLA in FIPS mode (#54048)

* Disable NLA in FIPS mode

* Disable NLA in FIPS mode

* lint

* Update docs for NLA in FIPS mode (#57310)
github-merge-queue bot pushed a commit that referenced this pull request Jul 30, 2025
* Disable NLA in FIPS mode (#54048)

* Disable NLA in FIPS mode

* Disable NLA in FIPS mode

* lint

* Update docs for NLA in FIPS mode (#57310)
github-merge-queue bot pushed a commit that referenced this pull request Jul 30, 2025
* Disable NLA in FIPS mode (#54048)

* Disable NLA in FIPS mode

* Disable NLA in FIPS mode

* lint

* Update docs for NLA in FIPS mode (#57310)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants