Skip to content

[v17] Avoid throttling on dynamodb DescribeStream #53804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
espadolini merged 2 commits into from
Apr 8, 2025
Merged

[v17] Avoid throttling on dynamodb DescribeStream #53804

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3119413
Wait a full second between refreshShards calls
espadolini Apr 7, 2025
a826a7a
Wait 200ms between DescribeStream calls
espadolini Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions lib/backend/dynamo/shards.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,8 @@ func (b *Backend) pollStreams(externalCtx context.Context) error {
b.buf.SetInit()
defer b.buf.Reset()

ticker := time.NewTicker(b.PollStreamPeriod)
defer ticker.Stop()
timer := time.NewTimer(b.PollStreamPeriod)
defer timer.Stop()

for {
select {
Expand All @@ -174,10 +174,11 @@ func (b *Backend) pollStreams(externalCtx context.Context) error {
} else {
b.buf.Emit(event.events...)
}
case <-ticker.C:
case <-timer.C:
if err := refreshShards(false); err != nil {
return trace.Wrap(err)
}
timer.Reset(b.PollStreamPeriod)
case <-ctx.Done():
b.logger.Log(ctx, logutils.TraceLevel, "Context is closing, returning.")
return nil
Expand Down Expand Up @@ -281,6 +282,12 @@ func (b *Backend) collectActiveShards(ctx context.Context, streamArn *string) ([
return filterActiveShards(out), nil
}
input.ExclusiveStartShardId = streamInfo.StreamDescription.LastEvaluatedShardId
select {
case <-ctx.Done():
// let the next call deal with the context error
case <-time.After(200 * time.Millisecond):
// 10 calls per second with two auths, with ample margin
}
}
}

Expand Down
Loading