Fix install script when using Managed Updates v2#53542
Merged
Conversation
sclevine
approved these changes
Mar 28, 2025
marcoandredinis
approved these changes
Mar 28, 2025
r0mant
approved these changes
Mar 28, 2025
public-teleport-github-review-bot
Bot
removed the request for review
from camscale
This was referenced Mar 28, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug causing the
teleport install autodiscover-nodecommand to fail when ran by the discovery ervice with the error:required argument 'token' not provided. This bug broke the discovery service in 17.3.0 and 16.5.0 with managed updates v2 enabled.Explanation: the oneoff.sh script was ending with $@, which passed the token to the command. The new script did not.
Changelog: Fix a bug causing the discovery service to fail to configure teleport on discovered nodes when managed updates v2 are enabled.