Merged
Conversation
espadolini
added
no-changelog
ravicious
approved these changes
Mar 27, 2025
rosstimothy
approved these changes
Mar 27, 2025
| _, err = newProxy.GetNodes(ctx, apidefaults.Namespace) | ||
| require.NoError(t, err) | ||
| require.EventuallyWithT(t, func(ct *assert.CollectT) { | ||
| _, err = testSrv.CloneClient(t, newProxy).GetNodes(ctx, apidefaults.Namespace) |
Contributor
There was a problem hiding this comment.
Should we be passing ct to CloneClient?
Suggested change
| _, err = testSrv.CloneClient(t, newProxy).GetNodes(ctx, apidefaults.Namespace) | |
| _, err = testSrv.CloneClient(ct, newProxy).GetNodes(ctx, apidefaults.Namespace) |
Contributor
Author
There was a problem hiding this comment.
No, failing to create the cloned client should stop the test (it has no reason to fail), and, as part of its creation, a cleanup is added to the test, which is not something that CollectT supports.
public-teleport-github-review-bot
bot
removed request for
capnspacehook,
kopiczko,
probakowski and
strideynet
Contributor
|
@espadolini See the table below for backport results.
|
This was referenced Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #52128 we've started taking just a little longer to update the cert pool for TLS connections on the auth, which has surfaced some flakiness in
lib/auth.TestRollback(as per #50047) caused by assuming that a freshly created client right after a CA rotation phase change would instantly be able to connect. This PR fixes the flakiness.Fixes #50047