followup: remove hardwarekey package aliases#53467
Closed
Joerger wants to merge 10 commits intojoerger/hardware-key-servicefrom
Closed
followup: remove hardwarekey package aliases#53467Joerger wants to merge 10 commits intojoerger/hardware-key-servicefrom
hardwarekey package aliases#53467Joerger wants to merge 10 commits intojoerger/hardware-key-servicefrom
Conversation
* Replace CustomHardwareKeyPrompt in ParsePrivateKeyOpts with HardwareKeyService * Export CLIPrompt
…rdware key prompt in favor in favor of hardware key service with prompt field.
…ions noted below: * Replace global *YubiKeyPrivateKey cache with a global *YubiKey cache, which supports proper cross-cluster connection caching for Connect * Replace HardwareSigner interface with HardwarePrivateKey, since the service within the key is now the interface * Add context to signatures through the context passed to the hardware key service * Only attest the key when needed (login) to avoid its performance cost
…ateKey; Add tests for marshaling/parsing hardware private keys and hardware key methods.
Joerger
force-pushed
the
joerger/hardware-key-service
branch
7 times, most recently
from
d14db39 to
cfcb9fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #53671