-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: hardware key service #53435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
feat: hardware key service #53435
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
4779b47
* Add HardwareKeyService interface and HardwarePrivateKey implementation
Joerger 66eab80
Propogate hardware key service through client store; Remove custom ha…
Joerger 7a21dc3
Add key info to HardwareKeyPrompt args instead of setting it in the p…
Joerger 1b8d036
Shift piv implementation into YubiKeyPIVService, with notable alterat…
Joerger 2a36bb6
Add hardwarekey and piv packages.
Joerger 8d7c4d8
Cleanup.
Joerger 72de3a1
Query hardware key for missing login key ref details.
Joerger 596ef2b
Cleanup piv slot constants; Combine NewPrivateKey and NewSoftwarePriv…
Joerger c2aae79
Cleanup.
Joerger abbf6c4
Revert setting shared hardware key service in teleterm; revert contex…
Joerger 159dc8b
Revert renaming NewSoftwarePrivateKey to NewPrivateKey.
Joerger 01c05bd
Revert replacing prompt in keystore with hardware key service in clie…
Joerger 0552e33
Fix tests.
Joerger d8daa45
Rename piv service files.
Joerger 66521ce
Add MockHardwareKeyService.
Joerger 7fe86f4
Use mock service in privatekey_test.go and remove pivtest build tag; …
Joerger 172ee50
Add more tests using the mocked hardware key service implementation.
Joerger cfcb9fb
fix or remove broken tests.
Joerger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| /* | ||
| Copyright 2025 Gravitational, Inc. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package keys | ||
|
|
||
| import "github.com/gravitational/teleport/api/utils/keys/hardwarekey" | ||
|
|
||
| // Temporary aliases for types moved to the hardwarekey or piv packages | ||
| // TODO(Joerger): Remove once /e no longer relies on them. | ||
|
|
||
| type AttestationStatement = hardwarekey.AttestationStatement | ||
|
|
||
| var AttestationStatementFromProto = hardwarekey.AttestationStatementFromProto |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| // Copyright 2025 Gravitational, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package hardwarekey | ||
|
|
||
| import ( | ||
| "bytes" | ||
|
|
||
| "github.com/gogo/protobuf/jsonpb" | ||
| "github.com/gravitational/trace" | ||
|
|
||
| attestationv1 "github.com/gravitational/teleport/api/gen/proto/go/attestation/v1" | ||
| ) | ||
|
|
||
| // AttestationStatement is an attestation statement for a hardware private key | ||
| // that supports json marshaling through the standard json/encoding package. | ||
| type AttestationStatement attestationv1.AttestationStatement | ||
|
|
||
| // ToProto converts this AttestationStatement to its protobuf form. | ||
| func (a *AttestationStatement) ToProto() *attestationv1.AttestationStatement { | ||
| return (*attestationv1.AttestationStatement)(a) | ||
| } | ||
|
|
||
| // AttestationStatementFromProto converts an AttestationStatement from its protobuf form. | ||
| func AttestationStatementFromProto(att *attestationv1.AttestationStatement) *AttestationStatement { | ||
| return (*AttestationStatement)(att) | ||
| } | ||
|
|
||
| // MarshalJSON implements custom protobuf json marshaling. | ||
| func (a *AttestationStatement) MarshalJSON() ([]byte, error) { | ||
| buf := new(bytes.Buffer) | ||
| err := (&jsonpb.Marshaler{}).Marshal(buf, a.ToProto()) | ||
| return buf.Bytes(), trace.Wrap(err) | ||
| } | ||
|
|
||
| // UnmarshalJSON implements custom protobuf json unmarshaling. | ||
| func (a *AttestationStatement) UnmarshalJSON(buf []byte) error { | ||
| return (&jsonpb.Unmarshaler{AllowUnknownFields: true}).Unmarshal(bytes.NewReader(buf), a.ToProto()) | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was moved from
hardwaresigner.go, no changes.