fix an issue expired app session won't redirect to login on DynamoDB backend#53238
Merged
fix an issue expired app session won't redirect to login on DynamoDB backend#53238
Conversation
greedy52
force-pushed
the
STeve/53091_fix_expired_app_session
branch
from
114ae8f to
f426020
Compare
bernardjkim
approved these changes
Mar 21, 2025
| server.StartTLS() | ||
| t.Cleanup(func() { | ||
| // Close fake remote site first to make sure fake listener quits. | ||
| fakeRemoteSite.Close() |
Contributor
There was a problem hiding this comment.
Should we still require that Close does not return an error?
espadolini
reviewed
Mar 24, 2025
espadolini
approved these changes
Mar 31, 2025
public-teleport-github-review-bot
Bot
removed request for
gabrielcorado and
timothyb89
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #53091:
changelog: fix an issue expired app session won't redirect to login page when Teleport is using DynamoDB backend
related:
github.com/gravitational/ttlmapdependency #46899App session object may still be retrievable after it expires with DynamoDB backend. Old ttlmap will cause
authenticateto fail as it won't create a new session when TTL is negative. However, this is not the case with FnCache replacement. Instead of fixing the AccessPoint cache or the local FnCache, this quick fix adds an explicit check on app session'sExpiry. Better solution should be explored to fix the general issue but i would like to deliver this quick fix now.