Clean up some request handling in the reverse tunnel agent#53200
Merged
espadolini merged 1 commit intomasterfrom Mar 20, 2025
Merged
Clean up some request handling in the reverse tunnel agent#53200espadolini merged 1 commit intomasterfrom
espadolini merged 1 commit intomasterfrom
Conversation
rosstimothy
approved these changes
Mar 19, 2025
gzdunek
approved these changes
Mar 20, 2025
Contributor
|
@espadolini See the table below for backport results.
|
espadolini
added a commit
that referenced
this pull request
Mar 21, 2025
espadolini
added a commit
that referenced
this pull request
Mar 21, 2025
espadolini
added a commit
that referenced
this pull request
Mar 21, 2025
This was referenced Mar 21, 2025
espadolini
added a commit
that referenced
this pull request
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up some of the SSH request and new channel handling in the reverse tunnel agent, including three separate occurrences of the same mishandling of closed channels that are selected on together with a context. Unfortunately a deeper fix that involves actually following the API contract of x/crypto/ssh (by actually exhausting all the relevant go channels rather than exiting on a context cancellation) could have other unforseen consequences in the handling of agents and their SSH connections in the agentpool and is thus out of scope for this specific fix.
Fixes #53165
changelog: fixed rare high CPU usage bug in reverse tunnel agents