Skip to content

[v15] Use default CDN Base URL by client tools managed updates for OSS build#53173

Merged
vapopov merged 4 commits intobranch/v15from
vapopov/enable-client-tools-autoupdate-for-oss-by-default
Mar 20, 2025
Merged

[v15] Use default CDN Base URL by client tools managed updates for OSS build#53173
vapopov merged 4 commits intobranch/v15from
vapopov/enable-client-tools-autoupdate-for-oss-by-default

Conversation

@vapopov
Copy link
Copy Markdown
Contributor

@vapopov vapopov commented Mar 18, 2025

In this PR added fix discovered during the testing tsh managed update from v 15.4.29-30 which was affected by previous backport of #51934

Since v15 licensed under Apache, we should always use default CDN for client tools managed updates

Build-tag: https://github.com/gravitational/teleport.e/actions/runs/13934159552

Changelog: Fixed an issue where the default CDN Base URL for client tools managed updates was incorrectly required for OSS builds.

@vapopov vapopov removed the backport label Mar 19, 2025
Comment thread Makefile
@vapopov vapopov added this pull request to the merge queue Mar 20, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 20, 2025
@vapopov vapopov added this pull request to the merge queue Mar 20, 2025
@vapopov
Copy link
Copy Markdown
Contributor Author

vapopov commented Mar 20, 2025

Verified on dev build, update is triggered by login to v17 cluster:

[root@vbox ~]# tsh version
Teleport v15.4.30-dev.vapopov.3 git:v15.4.30-dev.vapopov.3-0-g546ff08 go1.23.7
[root@vbox ~]# tsh login --proxy vadym.teleport.sh:443 --user vadym.popov@goteleport.com

WARNING
Detected potentially incompatible client and server versions.
Minimum client version supported by the server is 16.0.0-aa but you are using 15.4.30-dev.vapopov.3.
Please upgrade tsh to 16.0.0-aa or newer or use the --skip-version-check flag to bypass this check.
Future versions of tsh will fail when incompatible versions are detected.

Update progress: [▒▒▒▒▒▒▒▒▒▒] (Ctrl-C to cancel update)
Enter password for Teleport user vadym.popov@goteleport.com:

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 20, 2025
@vapopov vapopov enabled auto-merge March 20, 2025 05:04
@vapopov vapopov added this pull request to the merge queue Mar 20, 2025
Merged via the queue into branch/v15 with commit a934ccf Mar 20, 2025
34 checks passed
@vapopov vapopov deleted the vapopov/enable-client-tools-autoupdate-for-oss-by-default branch March 20, 2025 05:45
@fheinecke fheinecke mentioned this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants