Closed
Conversation
zmb3
reviewed
Mar 19, 2025
Collaborator
zmb3
left a comment
zmb3
left a comment
There was a problem hiding this comment.
Can we get some test coverage, or at least additions to the manual test plan?
| @@ -219,9 +219,7 @@ const auth = { | |||
| }, | |||
|
|
|||
| headlessSSOGet(transactionId: string) { | |||
Collaborator
There was a problem hiding this comment.
While we're here, it should be headlessSsoGet.
rosstimothy
reviewed
Mar 19, 2025
| @@ -234,10 +232,12 @@ const auth = { | |||
| headlessSSOAccept(transactionId: string) { | |||
Contributor
There was a problem hiding this comment.
If we're changing headlessSSOGet then we should also rename this to headlessSsoAccept.
| default: | ||
| err = trace.BadParameter("MFA response of type %T is not supported for headless authentication", mfaResp.Response) | ||
| emitHeadlessLoginEvent(ctx, events.UserHeadlessLoginApprovedFailureCode, a.authServer.emitter, headlessAuthn, err) | ||
| return err |
Contributor
There was a problem hiding this comment.
Shouldn't we still be returning this error?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Support SSO MFA as an MFA method for headless.