[v16] Machine ID: Warn when returned cert TTL is less than expected (#52833)#53103
Merged
timothyb89 merged 1 commit intobranch/v16from Mar 19, 2025
Merged
Conversation
* Machine ID: Warn when returned cert TTL is less than expected This adds a warning when the returned certificate TTL is lower than requested, which can happen if `max_session_ttl` is set in a bot role. Fixes #29579 * Add warning on most outputs; add TODO comment for future improvements * Mute slonglint false positivess
strideynet
approved these changes
Mar 18, 2025
boxofrad
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #52833 for branch/v16
Contains some tweaks to account for some v17-only changes, namely introduction of the
CredentialLifetimestruct.changelog: Machine ID: Added warning when generated certificates will not last as long as expected
This adds a warning when the returned certificate TTL is lower than requested, which can happen if
max_session_ttlis set in a bot role.Fixes #29579
Add warning on most outputs; add TODO comment for future improvements
Mute slonglint false positivess