[v16] Adding --join-method flag to teleport configure command#53060
Merged
WilliamLoy merged 5 commits intobranch/v16from Mar 14, 2025
Merged
[v16] Adding --join-method flag to teleport configure command#53060WilliamLoy merged 5 commits intobranch/v16from
WilliamLoy merged 5 commits intobranch/v16from
Conversation
Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
rosstimothy
approved these changes
Mar 14, 2025
Contributor
rosstimothy
left a comment
rosstimothy
left a comment
There was a problem hiding this comment.
Don't forget to add the changelog entry to the description.
codingllama
approved these changes
Mar 14, 2025
public-teleport-github-review-bot
Bot
removed the request for review
from camscale
Contributor
|
@WilliamLoy you are missing the changelog line in the PR description. Same for the other backport. |
tigrato
approved these changes
Mar 14, 2025
Contributor
Author
|
@codingllama does this need a changelog entry? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #52937
changelog: Added a --join-method
flag to theteleport configure` command