[v17] Machine ID: Warn when returned cert TTL is less than expected#53019
Merged
timothyb89 merged 3 commits intobranch/v17from Mar 13, 2025
Merged
[v17] Machine ID: Warn when returned cert TTL is less than expected#53019timothyb89 merged 3 commits intobranch/v17from
timothyb89 merged 3 commits intobranch/v17from
Conversation
This adds a warning when the returned certificate TTL is lower than requested, which can happen if `max_session_ttl` is set in a bot role. Fixes #29579
marcoandredinis
approved these changes
Mar 13, 2025
strideynet
approved these changes
Mar 13, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #52833 to branch/v17
changelog: Machine ID: Added warning when generated certificates will not last as long as expected