event-handler: allow DNS alternative names that don't resolve#53006
Merged
event-handler: allow DNS alternative names that don't resolve#53006
Conversation
hugoShaka
approved these changes
Mar 12, 2025
rosstimothy
approved these changes
Mar 12, 2025
Collaborator
Author
Yes. |
Remove the requirement that the DNS name resolves in order for it to be included in the configured certificates. This also changes the API so that IP SANs and DNS names are no longer mutually exclusive. Closes #52981
0c43ba5 to
3b3fc14
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 13, 2025
Documents #53006
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 15, 2025
…53026) * event-handler: allow DNS alternative names that don't resolve Remove the requirement that the DNS name resolves in order for it to be included in the configured certificates. This also changes the API so that IP SANs and DNS names are no longer mutually exclusive. Closes #52981 * Update event handler docs (#53021) Documents #53006
zmb3
added a commit
that referenced
this pull request
Mar 15, 2025
…53026) * event-handler: allow DNS alternative names that don't resolve Remove the requirement that the DNS name resolves in order for it to be included in the configured certificates. This also changes the API so that IP SANs and DNS names are no longer mutually exclusive. Closes #52981 * Update event handler docs (#53021) Documents #53006
zmb3
added a commit
that referenced
this pull request
Mar 15, 2025
…53026) * event-handler: allow DNS alternative names that don't resolve Remove the requirement that the DNS name resolves in order for it to be included in the configured certificates. This also changes the API so that IP SANs and DNS names are no longer mutually exclusive. Closes #52981 * Update event handler docs (#53021) Documents #53006
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 17, 2025
…53026) (#53064) * event-handler: allow DNS alternative names that don't resolve Remove the requirement that the DNS name resolves in order for it to be included in the configured certificates. This also changes the API so that IP SANs and DNS names are no longer mutually exclusive. Closes #52981 * Update event handler docs (#53021) Documents #53006
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 17, 2025
…53026) (#53063) * event-handler: allow DNS alternative names that don't resolve Remove the requirement that the DNS name resolves in order for it to be included in the configured certificates. This also changes the API so that IP SANs and DNS names are no longer mutually exclusive. Closes #52981 * Update event handler docs (#53021) Documents #53006
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the requirement that the DNS name resolves in order for it to be included in the configured certificates. This also changes the API so that IP SANs and DNS names are no longer mutually exclusive.
Closes #52981
changelog: The event handler can now generate certificates for DNS names that are not resolvable.