Add support for joining Kubernetes sessions in the web ui#52993
Merged
rosstimothy merged 1 commit intomasterfrom Mar 25, 2025
Merged
Add support for joining Kubernetes sessions in the web ui#52993rosstimothy merged 1 commit intomasterfrom
rosstimothy merged 1 commit intomasterfrom
Conversation
rosstimothy
force-pushed
the
tross/terminal_focus
branch
from
ccd7e0f to
9b897d2
Compare
rosstimothy
force-pushed
the
tross/kube_web_join
branch
20 times, most recently
from
1551f1e to
a54bc3e
Compare
github-actions
Bot
added
size/md
tsh
gzdunek
reviewed
Mar 19, 2025
Contributor
gzdunek
left a comment
gzdunek
left a comment
There was a problem hiding this comment.
Sorry for the delay, I'll test it tomorrow!
Comment on lines
+111
to
+115
| if (doc.mode === undefined) { | ||
| setStatus('waiting-for-exec-data'); | ||
| } else { | ||
| setStatus('initialized'); | ||
| } |
Contributor
There was a problem hiding this comment.
Can we combine it with the condition above?
Contributor
Author
There was a problem hiding this comment.
I would very much like to drop the else clause here and only set the initialized status in response to session data above. However when testing this last week, removing the else clause prevents things from working. @avatus and I couldn't really determine why that was the case.
Contributor
|
I can't join a session for some reason. I don't see anything interesting in the teleport logs. Do you have any idea what happens? |
rosstimothy
force-pushed
the
tross/kube_web_join
branch
2 times, most recently
from
c871c0d to
123a1ff
Compare
ryanclark
approved these changes
Mar 24, 2025
Contributor
Author
|
gzdunek
approved these changes
Mar 25, 2025
Contributor
gzdunek
left a comment
gzdunek
left a comment
There was a problem hiding this comment.
LGTM.
I tested all three joining modes and they work properly.
Adds the ability to join existing Kubernetes sessions in the web ui as peers, observers, or modertators. Closes #52315.
rosstimothy
force-pushed
the
tross/kube_web_join
branch
from
0b17ec2 to
1469c7b
Compare
Contributor
|
@rosstimothy See the table below for backport results.
|
rosstimothy
added a commit
that referenced
this pull request
Mar 26, 2025
Adds the ability to join existing Kubernetes sessions in the web ui as peers, observers, or modertators. Closes #52315.
rosstimothy
added a commit
that referenced
this pull request
Mar 26, 2025
Adds the ability to join existing Kubernetes sessions in the web ui as peers, observers, or modertators. Closes #52315.
rosstimothy
added a commit
that referenced
this pull request
Mar 26, 2025
Adds the ability to join existing Kubernetes sessions in the web ui as peers, observers, or modertators. Closes #52315.
zmb3
added a commit
that referenced
this pull request
Jun 5, 2025
We added support for joining kube sessions in the web UI with #52993 and just missed this docs update.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jun 6, 2025
We added support for joining kube sessions in the web UI with #52993 and just missed this docs update.
backport-bot-workflows Bot
pushed a commit
that referenced
this pull request
Jun 6, 2025
We added support for joining kube sessions in the web UI with #52993 and just missed this docs update.
backport-bot-workflows Bot
pushed a commit
that referenced
this pull request
Jun 6, 2025
We added support for joining kube sessions in the web UI with #52993 and just missed this docs update.
backport-bot-workflows Bot
pushed a commit
that referenced
this pull request
Jun 6, 2025
We added support for joining kube sessions in the web UI with #52993 and just missed this docs update.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jun 7, 2025
We added support for joining kube sessions in the web UI with #52993 and just missed this docs update.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jun 7, 2025
We added support for joining kube sessions in the web UI with #52993 and just missed this docs update.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jun 7, 2025
We added support for joining kube sessions in the web UI with #52993 and just missed this docs update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #52315
changelog: Enable support for joining Kubernetes sessions in the web UI.