Skip to content

[v17] fix: use SID directly in VNet Windows installer #52765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nklaassen merged 1 commit into from
Mar 4, 2025
Merged

[v17] fix: use SID directly in VNet Windows installer #52765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/vnet/install_service_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,15 +108,20 @@ func grantServiceRights() error {
if err != nil {
return trace.Wrap(err, "getting current service DACL")
}
// This is the universal well-known SID for "Authenticated Users".
authenticatedUsersSID, err := windows.StringToSid("S-1-5-11")
if err != nil {
return trace.Wrap(err, "parsing authenticated users SID")
}
// Build an explicit access entry allowing authenticated users to start,
// stop, and query the service.
ea := []windows.EXPLICIT_ACCESS{{
AccessPermissions: windows.SERVICE_QUERY_STATUS | windows.SERVICE_START | windows.SERVICE_STOP,
AccessMode: windows.GRANT_ACCESS,
Trustee: windows.TRUSTEE{
TrusteeForm: windows.TRUSTEE_IS_NAME,
TrusteeForm: windows.TRUSTEE_IS_SID,
TrusteeType: windows.TRUSTEE_IS_WELL_KNOWN_GROUP,
TrusteeValue: windows.TrusteeValueFromString("Authenticated Users"),
TrusteeValue: windows.TrusteeValueFromSID(authenticatedUsersSID),
},
}}
// Merge the new explicit access entry with the existing DACL.
Expand Down