[v16] Machine ID: Add Prometheus metrics for loop tasks (#52410)#52729
Merged
timothyb89 merged 1 commit intobranch/v16from Mar 11, 2025
Merged
[v16] Machine ID: Add Prometheus metrics for loop tasks (#52410)#52729timothyb89 merged 1 commit intobranch/v16from
timothyb89 merged 1 commit intobranch/v16from
Conversation
* Machine ID: Add Prometheus metrics for loop tasks This adds a number of Prometheus metrics to help track success, failure, and timing for loop iterations. The loop helper is used across tbot services, so these metrics universally cover identity and output renewals, among other tasks. Also, renames `service_heatbeat.go`, which was misspelled. * Include service name as a label; rename metrics for conventions
boxofrad
approved these changes
Mar 4, 2025
strideynet
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #52410 for branch/v16
changelog: Machine ID: Added new Prometheus metrics to track success and failure of renewal loops
This adds a number of Prometheus metrics to help track success, failure, and timing for loop iterations. The loop helper is used across tbot services, so these metrics universally cover identity and output renewals, among other tasks.
Also, renames
service_heatbeat.go, which was misspelled.