fix: support RSA PSS signatures with Windows VNet#52728
Merged
Conversation
zmb3
approved these changes
Mar 4, 2025
gzdunek
approved these changes
Mar 4, 2025
public-teleport-github-review-bot
bot
removed the request for review
from fspmarshall
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@nklaassen See the table below for backport results.
|
nklaassen
added a commit
that referenced
this pull request
Mar 4, 2025
Backport #52728 to branch/v17
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 4, 2025
Backport #52728 to branch/v17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the
crypto.Signerimplementation over gRPC that VNet uses on Windows when initiating mTLS connections to the proxy to support RSA PSS signatures. I didn't notice this bug during implementation because I was always using the newbalanced-v1signature algorithm suite, but this bug currently effects all users using thelegacysuite which still uses RSA keys for app access.The test added here fails and catches the bug before the fix, and passes with the fix.
Changelog: fixed VNet on Windows when the cluster uses the
legacysignature algorithm suite