Conversation
hugoShaka
commented
Mar 3, 2025
sclevine
approved these changes
Mar 3, 2025
sclevine
reviewed
Mar 3, 2025
examples/systemd/before-remove
Outdated
| else | ||
| echo "Removing symlinks from Teleport system paths..." | ||
| /opt/teleport/system/bin/teleport-update unlink-package || true | ||
| fi No newline at end of file |
hugoShaka
requested review from
fheinecke and
vapopov
and removed request for
gabrielcorado and
nklaassen
tigrato
approved these changes
Mar 3, 2025
Contributor
Author
|
Test build cooking here, will merge once we have an artifact and proof that the PR addresses both issues: https://github.com/gravitational/teleport.e/actions/runs/13635559487 |
hugoShaka
force-pushed
the
hugo/fix-rpm-linking-logic
branch
from
9440c81 to
0190f60
Compare
vapopov
approved these changes
Mar 3, 2025
public-teleport-github-review-bot
bot
removed the request for review
from fheinecke
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two RPM issues sharing the same root cause that went undetected until 17.3.0 release.
Issue 1:
link-packagefailslink-packageis supposed to run after we successfully installed teleport, to create symlinks to the teleport system install.RPM hooks are different than other packages and --after-install runs before the previous package removal. This means the old teleport binary has not been removed yet when we invoke
teleport-updater link-packageand causes an error.We cannot just overwrite the binaries because the old package removal will happen an tear down our symlinks.
Docs about RPM scriptlets ordering: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#ordering
Issue 2:
unlink-packageinvoked on updateThe uninstallation scriptlet is invoked after each package upgrade, which unlinks Teleport binaries from the system.
This can be detected by looking at the arguments passed by RPM to the scriptlet: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_syntax
Workaround
Both issues can be worked around by uninstalling and reinstalling the teleport package.
Because the 17.3.0 package potentially left teleport in a state without binaries after a failed update, we pulled 17.3.0 and are releasing 17.3.1.
Changelog: Fixes two issues in the 17.3.0 RPM causing package upgrades to fail and leading to teleport binaries not being symlinked in /usr/local/bin.
Changelog: On RPM-based distros, 17.3.0 can lead to a failed installation without a working Teleport service. The 17.3.0 RPM was pulled from our CDN. 17.3.1 should be used instead. If you updated to 17.3.0, you should update to 17.3.1.