Support setting app public-addr within Kubernetes app discovery#52642
Merged
Support setting app public-addr within Kubernetes app discovery#52642
Conversation
github-actions
Bot
requested review from
EdwardDowling,
mmcallister,
ptgott,
r0mant,
ravicious and
xinding33
Contributor
|
Amplify deployment status
|
rosstimothy
approved these changes
Mar 1, 2025
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> Signed-off-by: Zac Bergquist <zac.bergquist@goteleport.com>
zmb3
force-pushed
the
zmb3/pr-buddy-52459
branch
from
9ada2b0 to
05d4c66
Compare
greedy52
approved these changes
Mar 3, 2025
public-teleport-github-review-bot
Bot
removed request for
EdwardDowling,
mmcallister,
ptgott,
r0mant,
ravicious and
xinding33
zmb3
added a commit
that referenced
this pull request
Mar 3, 2025
…52642) Signed-off-by: Zac Bergquist <zac.bergquist@goteleport.com> Co-authored-by: Joao Ubaldo <me@joaoubaldo.com>
zmb3
added a commit
that referenced
this pull request
Mar 3, 2025
…52642) Signed-off-by: Zac Bergquist <zac.bergquist@goteleport.com> Co-authored-by: Joao Ubaldo <me@joaoubaldo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buddy PR for #52459
Closes #52458
Changelog: Support setting the public address for discovered apps based on Kubernetes annotations.