Disable legacy alpn connection upgrade fallback#52534
Merged
Conversation
greedy52
force-pushed
the
STeve/52397_disable_alpn_ping_upgrade_header
branch
from
6af389a to
d3e8609
Compare
r0mant
reviewed
Feb 26, 2025
r0mant
approved these changes
Feb 27, 2025
smallinsky
approved these changes
Feb 27, 2025
public-teleport-github-review-bot
bot
removed request for
ravicious and
tcsc
This was referenced Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related:
tsh#52397changelog: Disable legacy
alpnupgrade fallback during TLS routing connection upgrades. Now only WebSocket upgrade headers are sent by default.TELEPORT_TLS_ROUTING_CONN_UPGRADE_MODE=legacycan still be used to force legacy upgrades but it will be deprecated in v18.Note that this quick change does NOT implement a global setting as requested by #52397 but should allow Teleport to work in environment with stricter
Upgradeheader rules. Also note that we are not deprecating the legacy mode as it may still be used in certain environments, and the legacy mode has slight performance advantage.The WebSocket support is aded in v15.1, so the legacy fallback is still needed for v16. Thus this change will only be backported to v17.
Manually tested against AWS ALB. Integration tests also have simulated L7 LB tests.